search

DormSoup / dormsoup

MIT License
2 stars 0 forks source link

Added special handling in CompactEventCards for events with SIPB as the organizer. #16

Closed mitabreu closed 1 week ago

mitabreu commented 1 week ago

5: Added handling so that when a CompactEventCard is displaying an event organized by SIPB (as specified by the "organizer" property) confetti and SIPB's fuzzball is shown!

image

mitabreu commented 1 week ago

I think compareIgnoreCase can be put inside the CompactEventCard file, because util.ts should be mostly for functions that are shared across components, but otherwise LGTM, feel free to go ahead and merge it into main. Thanks for showing everyone how to do this!

I think compareIgnoreCase is pretty generic and could be used across components.

lad6558 commented 1 week ago

Sure, that makes sense too. Another option is to extract shared code into util.ts when sharing actually happens, which avoids bloating in util.ts, but this is a bit nit-picking. Either way works