Closed bjreisman closed 3 years ago
Merging #11 into master will decrease coverage by
0.02%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
- Coverage 12.11% 12.09% -0.03%
==========================================
Files 115 115
Lines 5968 5980 +12
==========================================
Hits 723 723
- Misses 5245 5257 +12
Impacted Files | Coverage Δ | |
---|---|---|
R/plot.drc.R | 48.01% <0.00%> (-2.18%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9de9a46...27fc7e4. Read the comment docs.
I've made two additions to the plot.drc function to fix the issues raised in #10.
The first fix is in the normalization block where previously the points would be reordered in alphabetical order by curveid; causing the curves to deviate from the plotted points. To prevent this behavior, each response is named by the order it appeared in the input data, normalized, then reordered by name to ensure it matches the original order.
The second fix is in the
type = 'bars'
code block. Ifnormal == TRUE
, the error bars are normalized using the same normalization code as before. Note that this may result in error bars that dip below 0 or above 1.See code below for examples: