search

Dosx001 / YouTubeUtils

Enhance your YouTube experience on desktop, mobile, and embed videos
4 stars 1 forks source link

Improve UX for changing video speed #4

Open shalva97 opened 8 months ago

shalva97 commented 8 months ago

As you can see in this video from another issue, changing speed is not easy, it is hard to select exactly 1 or 2.

There could be few buttons that will set a predefined speed.

https://github.com/Dosx001/YouTubeUtils/assets/22417494/d7bf05b0-94cb-4afa-a026-4282852ba509

Dosx001 commented 8 months ago

You want predefined speed buttons on the YouTubeUtils menu? I can do that. I'll work on that next weekend.

shalva97 commented 7 months ago

Is it possible to put those buttons on the video itself? that would be 100x better. It's not easy to navigate menus on a phone.

For example there can be one small button that would toggle the speed and show it. or some arrow icons that will change speed. Youtube uses material design so I drew it. I am not a designer but here is my piece of art :D image

I think arrows would be best

Dosx001 commented 7 months ago

So adding playback speed buttons would be pretty challenging. Adding the Loop button on desktop was dead simple, however on mobile, it was more complicated. I need to use a timed event, event handler, and a mutation observer to put the Loop button on mobile.

I might need to refactor my code. I need to put more thought for this feature. Don't expect this feature anytime soon.

Like, I said before I could easily add predefined playback speed buttons on the Addon menu. I could ship this by the end of the week.

Dosx001 commented 3 months ago

So finally separated the desktop and mobile UI. Now, I can do whatever I want with mobile UI.

I couldn't add the speed UI onto the YouTube player like the loop button because it felt super janky. Try continuously tapping on the loop button to see what I mean.

So I added a gear icon that opens a popup. I add the speed UI there. I also add a timeline for the video. I find the YouTube one to be slow and janky. My version works smoothly.

I could easily add more UI elements in the future, but for now, I'm going to work on some other stuff.

Also, the speed value defaults to the user's settings. Updating the value in the popup will only update the value temporarily. If you want to update the value permanently, you will need to go to the extension settings.

Screenshot_20240804-102740

Siva981 commented 2 months ago

@Dosx001

Browser: Firefox For Android (Latest Version)

Device: Android 12 (Samsung Galaxy M01)

1) I don't necessarily fiddle with the playback speed that often. Meaning, I don't need a persistent icon on the player itself. Could you please add an option in the Settings to turn this icon off?

2) I'm using version 1.13.1 of the addon, but i'm not seeing the gear icon from your screenshot above. Is it not live yet? Again, an option to hide this from the player would be nice.

3) The Subtitles zoom option is not working for me. It stays at the same size even if I increase it to 400%.

4) The video resizing option is not working for me either (no matter what option I choose from the dropdown in Settings). I would like an action similar to what happens in the YouTube Android App when we pinch & zoom to fill the screen and the app shows a pop up saying "zoomed to fill". I'm using the following extension for that purpose for now, and it works alright for me.

https://github.com/Dinoosauro/youtube-fullscreen-fit

shalva97 commented 2 months ago

it looks okay, but the colors are a bit too vivid. maybe you could also remove the border?

Is it published on addons page? how can I try it?