search

DotJoshJohnson / vscode-xml

XML Tools for Visual Studio Code
MIT License
322 stars 86 forks source link

Autoformat is completely broken, never finishes #266

Open Const-me opened 5 years ago

Const-me commented 5 years ago

Description

I've opened an XML with 13.5MB of data in assorted elements in a single line.

Autoformat never finishes while consuming a CPU core. Waited ~10 minutes and gave up.

I’m using 3.3GHz Xeon CPU with 16GB RAM.

Formatter Implementation

Both classic and v2 do the same

XML Tools Version

2.4.0

VS Code Version

1.28.2

Operating System

Windows 10

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

alexmejiaec commented 5 years ago

Got any workaround for this?

leotohill commented 5 years ago

XmlTools version 2.5. Windows 10. VSCode version 1.35.1.

Same problem here.
I formatted a 1.2MB file successfully - it took about 30 seconds to complete.

For a 3MB file it finally completed after 25 minutes. The file is well-formed. VSCode showed high cpu for the duration.

Is the run time per file size non-linear? Is it simply to be expected that large files will take a long time?

While it was running I noticed that the memory size of the process had a very regular cycle: baseline at about 500MB, quickly growing to about 1.3GB, then drop back. Repeat repeat repeat. The cycle length is about 10 seconds. Knowing that 1.3GB is close to the limit of a 32 process I wonder if it is getting a memory exception and restarting. But on the other hand I would expect this to be a 64bit process. Is it?