DotJoshJohnson / vscode-xml

XML Tools for Visual Studio Code
MIT License
320 stars 87 forks source link

Midline tabs inserted before comment #392

Open breyed opened 1 month ago

breyed commented 1 month ago

Description When an XML file has a comment after an element on the same line, the formatter adds tabs before the comment.

Repro:

  1. Set editorconfig to use tabs for indenting.
  2. Create an XML file with the “before formatting” content below.
  3. Format.

Notice that it results in the “after formatting” content, which has 2 tabs before the comment. It appears that the formatter is applying the 2 tabs necessary for a line indent at this level to an in-line comment case. It’s good that the comment is being kept on the same line, but the tabs should not be inserted.

Screenshots Before formatting:

<Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">
    <PropertyGroup>
        <TrimMode>full</TrimMode><!-- Comment -->
    </PropertyGroup>
</Project>

After formatting:

<Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">
    <PropertyGroup>
        <TrimMode>full</TrimMode>       <!-- Comment -->
    </PropertyGroup>
</Project>

Extension Version 2.5.1

VS Code Version 1.89.1

Operating System macOS 14.4.1