search

DotKuribo / BetterSunshineEngine

A modification of the SMS engine to provide nifty features like audio streaming, no boot shines, extra shines, and more.
GNU General Public License v3.0
32 stars 7 forks source link

Ledge Grab Movement Issue #28

Open McAchi opened 2 months ago

McAchi commented 2 months ago

Issue only applies when Collision Fixes is ON. ( Issue is both on 30 and 60 FPS ).

Issue was found in Noki Bay, with the tight ledges that Mario has to grab onto to move around high up on the walls.

Some spots on the ledges seem to act as one-way walls, where Mario gets pushed from one side, and blocked from the other. The spots are consistent ( always the same ). My theory is the Collision Fixes don't take the weird world geometry into account, therefore wacky behaviour.

( Unrelated, but is it possible for pre-rendered cutscenes to fill the whole screen in 16:9, since that's how they were rendered? )

Thank you, and great mod!

JoshuaMKW commented 2 months ago

I'll have to check that out. As for the THPs, this likely isn't going to happen due to how the cutscenes were rendered in 16:9 (baked black borders), and the general logistical issue of convincing the THP player to crop out pixels on the top and bottom without things freaking out.

McAchi commented 2 months ago

I knew them black borders were to blame, but that's not a big deal. Hope that finding out what makes those ledges wack isn't too difficult, wish you luck! Thank you!

JoshuaMKW commented 2 months ago

Ledges are now fixed but I'll wait to close until it makes its way to a release.

McAchi commented 2 months ago

Alright, good to know. Thanks again!