updated neo4j driver to 5.14

DotNet4Neo4j / Neo4jClient

.NET client binding for Neo4j

https://www.nuget.org/packages/Neo4jClient

Microsoft Public License

431 stars 146 forks source link

updated neo4j driver to 5.14 #474

Closed VictorFZ closed 10 months ago

VictorFZ commented 10 months ago

Hello, @cskardon ! Nice to meet you.

I am using this lib for my Neo4j Connection and I find it REALLY usefull. Thank for sharing this superb code.

I am using neo4j in production, implementing a really customized and powerfull graph api with a more "resfull pattern" that I hope to make it open source really soon.

I am making some tests, and we are having some "connection reset by peer" with our neo4j server, and one of the first things we are trying to do is update the driver itself, so I made this PR for this reason, because I realised that the neo4j driver was not up to date, so I am updating it to the latest version, from 5.7 to 5.14.

This new implementation has 3 new methods on IDriver, so I implemented them using the same pattern as used on the other implementations.

Can you please review it?

Thanks in advance, have a good day

EDIT: linked issue: https://github.com/DotNet4Neo4j/Neo4jClient/issues/472

DarthSonic commented 10 months ago

Is this project still being maintained at all? If not, that would be a great pity. I would also appreciate a merge to support the new driver version, as our web project is based on this project and would be unthinkable without it. We also have the "connection reset by peer" error and the new driver version could possibly fix this!

cskardon commented 10 months ago

Hi, unfortunately I also have a lot of commitments both in life and work, and as this is free, and takes up a lot of time it is low priority at the moment.

I just didn't receive a notification about the PR, otherwise I would have done it earlier 🤷🏻‍♀️ - so that's very much on me/interwebs.

I suspect the update won't fix the issue, as from what I know it's a different problem, but it's good to have it on the latest version, and fingers crossed it will help 🤞🏻

VictorFZ commented 10 months ago

Hi @cskardon and @DarthSonic !

For the "connection reset by peer", even though the Neo4j support said that the driver update would fix this, I still did 1 change in my services:

Added a liveness probe to check the neo4j connection, if it failed based on this error, restart the instance.

The other possible solution would be:

Catch this specific error and re-create the driver instance (that is a singleton) when this error happens. This also seems to resolve the issue.

Hope this helps, @DarthSonic

And thanks for the merge, @cskardon !