search

DotNetAnalyzers / AspNetCoreAnalyzers

MIT License
62 stars 4 forks source link

[PR] The proj files have been updated to enable SourceLink #69

Closed JTOne123 closed 4 years ago

JTOne123 commented 4 years ago

CSProj files have been updated to enable SourceLink in your nuget

[This pull request was created with an automated workflow]

I noticed that your repository and Nuget package are important for our .NET community, but you still haven't enabled SourceLink.

We have to take 2 steps: 1) Please approve this pull request and make .NET a better place for .NET developers and their debugging. 2) Then just upload the .snupkg file to https://www.nuget.org/ (now you can find the snupkg file along with the .nuget file)

You can find more information about SourceLine at the following links
https://github.com/dotnet/sourcelink https://www.hanselman.com/blog/ExploringNETCoresSourceLinkSteppingIntoTheSourceCodeOfNuGetPackagesYouDontOwn.aspx

If you are interesting about this automated workflow and how it works
https://github.com/JTOne123/GitHubMassUpdater

If you notice any flaws, please comment and I will try to make fixes manually

JohanLarsson commented 4 years ago

I'm not opposed to merging this but out of curiosity how is SourceLink useful for an analyzer?

JTOne123 commented 4 years ago

it better to add this package through the paket

but I don't know if it makes sense for your nuget

Could the user make use of class from your lib?

JohanLarsson commented 4 years ago

Could the user make use of class from your lib?

Using the code as a library is theoretically possible but I usually write analyzers so that everything is internal. Also not sure if there is a straightforward way to use it like this when packed like an analyzer.

JTOne123 commented 4 years ago

agree

sorry for a mismatch, I've closed my PR