search

DotNetAnalyzers / NullParameterCheckRefactoring

Null Parameter Check Refactoring for Reference Type Parameters
MIT License
14 stars 4 forks source link

Visual Basic support #15

Closed sharwell closed 10 years ago

sharwell commented 10 years ago

This pull request adds the Visual Basic support implemented by @AdamSpeight2008. Fixes #6.

tugberkugurlu commented 10 years ago

I guess file renames wiped all file history but there is nothing to do there :disappointed: looks good to me.

sharwell commented 10 years ago

Must be a GitHub limitation of anything. Git itself has no trouble tracking files through the rename here, even for operations like rebase.

tugberkugurlu commented 10 years ago

I cannot seem to get it working when I F5 to test it inside the experimental hive:

screenshot 2014-11-19 14 18 38

Am I doing something wrong?

tugberkugurlu commented 10 years ago

It seems that the problem is the node target. It only sees the node as ParameterSyntax when you select the whole parameter:

screenshot 2014-11-19 14 23 40

I would assume to get the refactoring suggestion when my cursor is around the parameter name as below but the node seems to be the ModifierIdentiferSyntax:

screenshot 2014-11-19 14 23 29

sharwell commented 10 years ago

Is there anything here that still needs to be fixed prior to the initial "merge"? Since the request contains file moves it helps to include it early so people can work from a new reference point.

tugberkugurlu commented 10 years ago

@sharwell Can we do something for this (I have no idea if it's safe to watch for ModifierIdentiferSyntax node instead of ParameterSyntax)? https://github.com/DotNetAnalyzers/NullParameterCheckRefactoring/pull/15#issuecomment-63632481

It seems pretty annoying but if this is the way it should be, :shipit:

sharwell commented 10 years ago

If the behavior is unintuitive we can file a separate issue.

tugberkugurlu commented 10 years ago

That's fine, I'm getting it in then. I will open up the issues as well.