search

DotNetDevs / Synology

Synology Client for Build-In APIs for .NET Projects
https://dotnetdevs.github.io/Synology/
Apache License 2.0
55 stars 18 forks source link

Complete FileStation APIs #31

Open matteobruni opened 9 years ago

Matt-Co commented 8 years ago

Hi Matteo, I will implement the SYNO.FileStation.CopyMove and SYNO.FileStation.Rename methods which are both available from DSM 6.0. Should I create a Synology.FileStation2 project / assembly ?

matteobruni commented 8 years ago

Hi, No, I'm thinking about merging the two DownloadStation projects again, I thought the APIs have different names. About breaking DSM pre 6.0 support, don't worry, I'll open an issue about it. If someone uses it, it can revert the nuget update to a previous working version for now.

Matt-Co commented 8 years ago

Ok, thanks for your answer... I'll let you know when complete :)

matteobruni commented 8 years ago

After inspecting the Syno.API.Info I've seen there's a DownloadStation2 and a DownloadStation, so the project will remain separated. FileStation instead is still a single api, so a single project is the current solution.

Matt-Co commented 8 years ago

Hi Matteo, I'm trying to sync my commits with the server (I implemented the SYNO.FileStation.List methods) but I have the following error : Failed to push this branch the branch does not pass the required status check 'continuous-integration/appveyor/pr'.

And I don't know how and where to get more information on what's wrong...

Could you help please. Thanks. Mathieu

matteobruni commented 8 years ago

Where are you pushing?

Matt-Co commented 8 years ago

SYNO.FileStation.List on your latest commit (merged).

matteobruni commented 8 years ago

Branch?

Matt-Co commented 8 years ago

On dev !

matteobruni commented 8 years ago

Try now, it should work

Matt-Co commented 8 years ago

It worked. Next time, I'll know.

Thanks

matteobruni commented 8 years ago

It was a wrong setting on branch, sorry

Matt-Co commented 7 years ago

Hi Matteo, I'm trying to modify the SYNO.FileStation.CopyMove api because there is an issue on the start method. I forked the Synology.FileStation repository but when I load it in VS, the Synology dependency is not retrieved by Visual Studio (except when I build, in this situation, the nuget package is well downloaded and added to the build pipeline). Can you explain me how to get a correct development environment (my last commit is a bit old and many updates have been done since).

Thanks Matt

matteobit commented 7 years ago

Hi, The nuget package is fine for developing with the Synology.FileStation project. If you need to edit both reference your local Synology project and do all the changes you need, then push the main project changes and create a pull request, when all tests are passed you could merge it to master and wait the new nuget package to be published. You reference it in the FileStation project and push it, create then the new pull request and when all tests are passed you could merge it to master and the new version will be published. It's a little bit tricky for the waiting of the new package version. Otherwise push it with the local references and I'll fix it ASAP.

lyellick commented 4 years ago

Hello. Thanks all for making/contributing to a great library that is .net core ready. Any chance on building the create/delete of a folder or file in the near future? No worries if no. :)

matteobruni commented 4 years ago

Hi @lyellick, thanks for the suggestion. I was thinking about working again on this project some weeks ago. I try to work on that ASAP, if you want to contribute feel free to submit a PR

lyellick commented 4 years ago

@matteobruni I have already started trying add this enhancement but I still have the learning curve of the FileStation API. 😅

Take care!