search

DoubangoTelecom / sipml5

The world's first HTML5 SIP client (WebRTC)
BSD 3-Clause "New" or "Revised" License
935 stars 455 forks source link

Call Hold/Resume Fails #361

Open sbpkhostings opened 2 years ago

sbpkhostings commented 2 years ago

I am using the API version 2.1.4

When the call is placed on hold and then resumed, the previous media stream is no longer continued. The receiver does not get any audio.

surfrock66 commented 2 years ago

We fixed this by making the resume asynchronous and using "replaceTrack" instead of "addTrack" which adds another Sender, instead of updating tracks in the existing sender. We think this is a change from the WebRTC API from when this was originally developed. Our commit is a giant bundled commit so a pull request isn't gonna just work easily, but the code is here on line 450 of this commit: https://github.com/L1kMakes/sipml5-ng/commit/6fd731d57e79fb2e07e2fc84f216a1d4fd63ef21#diff-0ca66776a62cfb4af660b32adc09131b21a58c29741db80e237ee710eb2ce5e6

YasinKara commented 1 year ago

I solved this problem by transferring the user to herself when he click to resume button.