search

DoubangoTelecom / webrtc-plugin

WebRTC plugin for IE
GNU General Public License v3.0
12 stars 7 forks source link

Need Promise based enumerateDevices API #11

Closed MikeBlair closed 7 years ago

MikeBlair commented 7 years ago

Please expose a Promise based enumerateDevices API

DoubangoTelecom commented 7 years ago

Already returning a promise. Sample: https://doubango.org/rtc-plugin/samples/src/content/devices/input-output/ Please explain what you mean by "expose".

MikeBlair commented 7 years ago

My team will provide more info on this tomorrow.

MikeBlair commented 7 years ago

We are working on a sample to show you this issue.

ptownsend commented 7 years ago

This seems to be related to issue https://github.com/DoubangoTelecom/webrtc-plugin/issues/15.

The object returned by this function does not work like a promise is expected to, and breaks promise chains when attempting to .then after the initial .then and .catch.

Please see the example here: https://ptownsend.github.io/enumerate-devices-test.html

Try in Chrome, then in IE using the plugin.

The temasys plugin returns a promise as expected, if you try in IE here: https://ptownsend.github.io/enumerate-devices-temasys.html

DoubangoTelecom commented 7 years ago

Fix is part of installer 1.2.0: https://doubango.org/rtc-plugin/setup.exe You should see empty strings on the webpage but correct ones in the console logs. Related to issue #17