search

Double-Fine-Game-Club / pongball

Pongball is a team based multiplayer game blending pong and pinball.
https://forums.doublefine.com/forum/80-pongball/
MIT License
11 stars 17 forks source link

Implemented table_kednar and my variants - seems to work! #108

Closed kednar closed 7 years ago

kednar commented 7 years ago

Heh! I knew I was missing something :D Sadly I am out until later, could you please reach KGuNN so he fixes it? Thank you!

On 26 Apr 2017 13:32, "Cheeseness" notifications@github.com wrote:

@Cheeseness requested changes on this pull request.

This is looking great! Good job on pulling it all together!

It's got some things that I think should be addressed before merging though:

  • Shared materials should go in the Assets/entities/shared/Materials folder
  • The ceiling needs to be lowered so that the ball can't bounce over paddles (it might need to be curved to match the terrain!)
  • Your table doesn't seem to use the variant system properly (selecting other variants doesn't use their bumpers, etc.)
  • Bumpers need to be given the bumper tag so that they'll make bumper sounds
  • Walls need to be given the wall tag so that they'll make wall sounds

Other than that, it looks good!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Double-Fine-Game-Club/pongball/pull/108#pullrequestreview-34814341, or mute the thread https://github.com/notifications/unsubscribe-auth/AHayw-OnEEDvfYlKA4PbB60q9ie1AS1Pks5rzytngaJpZM4NIspX .

kednar commented 7 years ago

Note: the ceiling mesh is already curved as the ground.

Cheeseness commented 7 years ago

Note: the ceiling mesh is already curved as the ground.

Ah, OK! I think it needs to be lowered then. The new paddle collider is very tall compared to the old one and it still bounces overhead pretty often.

fragmental commented 7 years ago

I think you can also make unity cubes, position them, and turn off their mesh render. Not ideal but might be useful in some situations.

Cheeseness commented 7 years ago

I think we want to address a couple of things (lightpad behaviour, separating wall geometry and maybe trying to deal with the one-sidedness of the spinner, but other than that, it's looking good enough for now!

Merged! \o/

fragmental commented 7 years ago

Gj @kednar \o/

On Apr 26, 2017 7:26 PM, "Cheeseness" notifications@github.com wrote:

Merged #108 https://github.com/Double-Fine-Game-Club/pongball/pull/108.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Double-Fine-Game-Club/pongball/pull/108#event-1059592862, or mute the thread https://github.com/notifications/unsubscribe-auth/AE1A8Dn_Yj8I_oZXxGrORJypYOCTfruUks5rz-CogaJpZM4NIspX .

fragmental commented 7 years ago

Importing tables can sometimes be a pita. I know this from experience. I probably should have made some concrete import instructions when I first successfully imported table2

On Apr 26, 2017 7:27 PM, "Stewart Martin" stewartjmartin@gmail.com wrote:

Gj @kednar \o/

On Apr 26, 2017 7:26 PM, "Cheeseness" notifications@github.com wrote:

Merged #108 https://github.com/Double-Fine-Game-Club/pongball/pull/108.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Double-Fine-Game-Club/pongball/pull/108#event-1059592862, or mute the thread https://github.com/notifications/unsubscribe-auth/AE1A8Dn_Yj8I_oZXxGrORJypYOCTfruUks5rz-CogaJpZM4NIspX .