Double-Fine-Game-Club / pongball

Pongball is a team based multiplayer game blending pong and pinball.
https://forums.doublefine.com/forum/80-pongball/
MIT License
11 stars 17 forks source link

Adjust ui text and add back buttons #143

Open jctwizard opened 7 years ago

jctwizard commented 7 years ago

Adds back buttons with a stack of menu panels. Make sure if you add a new menu panel in the script you push it onto the stack. Tested all the menu paths and seems to work perfectly. Also changed the buttons to look slightly less generic.

jctwizard commented 7 years ago

Ah damn i think i increased the text size right before pushing forgetting some of it would not appear on lower resolutions.

On Thu, 27 Apr 2017 at 19:03, Kjell Iwarson notifications@github.com wrote:

@lightsoda requested changes on this pull request.

Unfortunately a lot of the text is not visible in the setup menu. http://pasteboard.co/WpldBGts.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Double-Fine-Game-Club/pongball/pull/143#pullrequestreview-35180597, or mute the thread https://github.com/notifications/unsubscribe-auth/AHxweuloCGQKH3n4GkNdcWsfYnRTrzHTks5r0NhugaJpZM4NKjSC .

fragmental commented 7 years ago

I generally use "best fit" with min max values and that solves a lot of issues with font size. If the min value is too high this issue could still appear on lower resolutions. Another option is to change canvas scaling but that affects everything.

jctwizard commented 7 years ago

The reason I turned off best fit was because all the text was inconsistent. With a font size of 30 it was legible at the smallest and largest resolution but then I upped it to 40 without testing properly.

On Fri, 28 Apr 2017 at 09:13, Stewart Martin notifications@github.com wrote:

I generally use "best fit" with min max values and that solves a lot of issues with font size. If the min value is too high this issue could still appear on lower resolutions. Another option is to change canvas scaling but that affects everything.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Double-Fine-Game-Club/pongball/pull/143#issuecomment-297936837, or mute the thread https://github.com/notifications/unsubscribe-auth/AHxweghyWzoyWRchnqb2MS8HWD_XJKNNks5r0Z-pgaJpZM4NKjSC .

fragmental commented 7 years ago

Oh right. That makes sense. I've also use content size fitters to force objects to fit my text but that doesn't apply here.

jctwizard commented 7 years ago

@lightsoda I have reverted the font size back down to its previous size and it is visible at the lowest resolution I can run the game at now. This only affects the setup menu and does not touch the main menu.

ghost commented 7 years ago

I seem to have the same problem on this branch. Can't see play instructions before match.

Cheeseness commented 7 years ago

I think this still needs changing to work with intervening updates to BaseTable.unity that were needed for the Humble Release. @jctwood are you comfortable reworking things? If not, just sing out :)