search

Double-Fine-Game-Club / pongball

Pongball is a team based multiplayer game blending pong and pinball.
https://forums.doublefine.com/forum/80-pongball/
MIT License
11 stars 17 forks source link

Remove Load Assets and Basic Menu Script from Network Manager Game Object #181

Closed fragmental closed 7 years ago

fragmental commented 7 years ago

Remove Load Assets and Basic Menu Script from Network Manager Game Object. These were left over from making the new menu.

@jctwood is there any reason we should continue to leave these two scripts on the Network Manager object or is it fine to remove them?

Cheeseness commented 7 years ago

I think BasicMenu.cs is dead code now? Makes sense to remove it from the project entirely if it's not being used.

fragmental commented 7 years ago

Probably. We left BasicMenu there as a backup in case we couldn't get the new gui up and running before the end of AF, but it's superfluous now.

Still, I'd be more comfortable waiting on word from @jctwood before removing it entirely from the project.

Cheeseness commented 7 years ago

It makes sense to remove unused stuff as part of PRs. We can always grab it from the repo history if we need to check stuff or revert changes.

No rush on this one. It's not a critical issue - just something to do to avoid confusion in the future.

jctwizard commented 7 years ago

Just woke up those are dead as Fragmental said they were there in the case of a backup. On Tue, 2 May 2017 at 08:01, Cheeseness notifications@github.com wrote:

It makes sense to remove unused stuff as part of PRs. We can always grab it from the repo history if we need to check stuff or revert changes.

No rush on this one. It's not a critical issue - just something to do to avoid confusion in the future.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Double-Fine-Game-Club/pongball/issues/181#issuecomment-298514125, or mute the thread https://github.com/notifications/unsubscribe-auth/AHxweh8yjuphikpWUxDKVV3IbIWVeME1ks5r1tTQgaJpZM4NNv6q .