search

Double-Fine-Game-Club / pongball

Pongball is a team based multiplayer game blending pong and pinball.
https://forums.doublefine.com/forum/80-pongball/
MIT License
11 stars 17 forks source link

Music Testing Debug.Log by Pressing "T" #184

Closed fragmental closed 7 years ago

fragmental commented 7 years ago

Added a function that prints the results of musicSource.isPlaying to the debug.log for testing #151

ghost commented 7 years ago

Can't you just test this locally? Why a PR.

fragmental commented 7 years ago

I can and will test it locally when I'm awake later. The pr is in case anyone else wants to test. Since this bug doesn't happen often or regularly.

On May 2, 2017 4:34 AM, "Kjell Iwarson" notifications@github.com wrote:

Can't you just test this locally? Why a PR.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Double-Fine-Game-Club/pongball/pull/184#issuecomment-298577402, or mute the thread https://github.com/notifications/unsubscribe-auth/AE1A8CfxKIbrzjir_zUPHpwVnmyvsgwhks5r1viRgaJpZM4NN2bu .

fragmental commented 7 years ago

And it's for @Cheeseness. He wanted to know if isPlaying was running when the bug happened so I added some code to do that.

On May 2, 2017 5:02 AM, "Stewart Martin" stewartjmartin@gmail.com wrote:

I can and will test it locally when I'm awake later. The pr is in case anyone else wants to test. Since this bug doesn't happen often or regularly.

On May 2, 2017 4:34 AM, "Kjell Iwarson" notifications@github.com wrote:

Can't you just test this locally? Why a PR.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Double-Fine-Game-Club/pongball/pull/184#issuecomment-298577402, or mute the thread https://github.com/notifications/unsubscribe-auth/AE1A8CfxKIbrzjir_zUPHpwVnmyvsgwhks5r1viRgaJpZM4NN2bu .

fragmental commented 7 years ago

And I'm going to sleep

On May 2, 2017 5:06 AM, wrote:

And it's for @Cheeseness. He wanted to know if isPlaying was running when the bug happened so I added some code to do that.

On May 2, 2017 5:02 AM, "Stewart Martin" stewartjmartin@gmail.com wrote:

I can and will test it locally when I'm awake later. The pr is in case anyone else wants to test. Since this bug doesn't happen often or regularly.

On May 2, 2017 4:34 AM, "Kjell Iwarson" notifications@github.com wrote:

Can't you just test this locally? Why a PR.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Double-Fine-Game-Club/pongball/pull/184#issuecomment-298577402, or mute the thread https://github.com/notifications/unsubscribe-auth/AE1A8CfxKIbrzjir_zUPHpwVnmyvsgwhks5r1viRgaJpZM4NN2bu .

Cheeseness commented 7 years ago

To avoid confusion, let's keep PRs for code that we want merged into the main codebase. It's better to link to a branch if your own fork with this kind of stuff.