Emulator crashes when recording new movie

[GoogleCodeExporter]

What steps will reproduce the problem?
1. record new movie
2.
3.

What is the expected output? What do you see instead?
starting recording, but crashed.

What version of the product are you using? On what operating system?
vba v24m svn r461

Please provide any additional information below.

Original issue reported on code.google.com by pkmnwww...@yahoo.com on 14 Dec 2012 at 10:47

[GoogleCodeExporter]

Found the issue - it's specific to GameBoy recording.  

In MovieCreate.cpp, MovieCreate::OnBnClickedOk() calls systemLoadBIOS, which in 
turn calls CPULoadInternalBios.  That function copies an internal bios, but 
fails to check if it's safe to do so.  

Attached two replacement files. MovieCreate.cpp in src\win32\Dialogs and 
Gba.cpp in src\gba\V8 - former doesn't bother loading the bios when "No Bios" 
option is checked (only possible choise in GB, and there's already a bios 
loaded by then), and the latter guarantees enough space to prevent that 
function from causing further trouble. 

Original comment by raymond....@gmail.com on 16 Jan 2013 at 1:40

Attachments:

• MovieCreate.cpp
• gba.cpp

[GoogleCodeExporter]

Fixed on r466. Thanks for the attachments, though I am not a big fan of the 
re-calloc and I excluded it.

Original comment by aquan...@gmail.com on 5 Apr 2013 at 9:35

• Changed state: Fixed