DoubleDoorDevelopment / ItemBlacklist

Now is not the time to use that. (Dimension based item filter)
MIT License
7 stars 5 forks source link

Meta(damage) data not working for banned item - acting as wildcard "*" #5

Open rob5251 opened 8 years ago

rob5251 commented 8 years ago

If I ban an item and set its meta (damage) value it does block the correct item, but it also blocks all other values of that item as well. The item wont get locked and turn into the locked version of the item, it just wont let you place/use it and it still displays the notice of it being banned in chat.

This is my blacklist file: http://pastebin.com/a4CykeHd

Image of example item: http://imgur.com/kBiGLBo Both have the same item name but different meta value, I only have one actually blocked in my blacklist file though.

dries007 commented 8 years ago

Are you sure? It works here... You need to try and use the sapling before it will realize it should be banned btw.

rob5251 commented 8 years ago

I place the one sapling and it locks, I try to place the other sapling and it just puts it back in my inventory and displays the warning message, but it doesnt lock.

Only one version of the sapling is suppose to be banned though.

rob5251 commented 8 years ago

You left a comment in the wrong repository

Can you try with another item? I just did more testing and it definitely works with vanilla items.

I tried out /blockitem ban __GLOBAL__ minecraft:wool:0 it is doing it with wool as well. I cant place white wool, it locks like it should. However I can't place any other wool either, it doesn't lock just jumps back to inventory with warning message in chat.

Claycorp commented 8 years ago

Confirmed it is broken on servers. Tested client and multiplayer and it only comes up in multiplayer.

(This was with the old version not the new one that was just uploaded) @dries007 Is testing the new one currently

jelaw21 commented 7 years ago

This is still not functioning for servers. Using newest .08 version for 1.7.10. ThermalExpansion is a big one to test as the creative block is metadata 0 and the rest start at 1. It keeps banning ALL thermalexpansion power cells. Thanks.

dries007 commented 7 years ago

Is it possible this is because they store the information in NBT and not metadata?

jelaw21 commented 7 years ago

I'm not sure. I tried /blacklist ban ThermalExpansion:cell:0. The config put the 0 in the damage tag, but it blocked ALL ThermalExpansion powercells. I am currently running Project Ozone 2.

dries007 commented 7 years ago

Would you mind using an item exporter (like Minetweaker's /mt hand) command to export a couple of the cell's information and share it on here? (I don't have the time to setup a pack and test myself.)

jelaw21 commented 7 years ago

Sure thing give me a few.

jelaw21 commented 7 years ago

Creative Cell (the one I am trying to blacklist) image

Normal Cell (also getting blacklisted, but should be available to players) image

dries007 commented 7 years ago

OK, I'm re-opening and will test when I have some time, sorry I can't do more now.