search

DoubleDoorDevelopment / Lumberjack

Boom. Tree gone!
BSD 3-Clause "New" or "Revised" License
5 stars 7 forks source link

MC 1.12 #22

Closed hron84 closed 5 years ago

hron84 commented 7 years ago

Could you please investigate if 1.12 is potentially can get this mod? It would perfectly fit my near-vanilla pack.

DrDarkfire commented 6 years ago

I second that. I would have the need for that my 1.12 Packs

spikespaz commented 6 years ago

I'm already working on a 1.12 port. Once I've finished it I'll open a pull request here, it looks like this repo is mostly inactive.

https://github.com/essentialmc/lumberjack

dries007 commented 6 years ago

I have not looked into porting to 1.12 yet, I doubt it's even possible. Hence why no replies yet. I'm glad someone else is, because it was low on my priority list and I unfortunately have little time.

spikespaz commented 6 years ago

@dries007 How does your versioning scheme work?

dries007 commented 6 years ago

I don't increment versions if it's a straight port from one MC version to the next (with equal features). If the port required significant changes, or the config has changed, I increment, depending on how severe the breakage, it's minor or patch.

I usually reserve major version changes for when a complete rewrite is required or when I feel the changes with the previous version is so great, it might as well be a new mod.

Oh and jar files should always be <MC>-<Version>[.<BuildNR>].

spikespaz commented 6 years ago

@dries007 I see D3Core has been updated to 1.12, however your maven repo results in a 404.

http://doubledoordev.net/maven

dries007 commented 6 years ago

Maven is dead, I recommend doing it like JsonLootBags.

Claycorp commented 5 years ago

There is a limited 1.12 version available now, Closing this.