Item duplication glitch interaction with Backpacked

[KittenRaee]

When oversize item is inserted into the backpack, it pops out as intended, but leaves item copied inside the backpack slot. Logs don't return any errors.

[Claycorp]

What backpack from what mod? There's a 99.99% I can't fix this without special casing it as I'm not seeing any item/block that holds the contents to modify at close time.

[MrCrayfish]

The backpack mod is mine. It's due to the inventory being saved before PlayerContainerEvent.Close is fired. This sounds like an issue that is not exclusive to my mod. This applies to any mod that has code in Container#onContainerClosed and does any logic with the inventory. Just a few examples but probably more.

• https://github.com/gr8pefish/IronBackpacks/blob/dev-1.12/src/main/java/gr8pefish/ironbackpacks/container/ContainerBackpack.java#L125
• https://github.com/Darkona/AdventureBackpack2/blob/master/src/main/java/com/darkona/adventurebackpack/inventory/ContainerBackpack.java#L155

All I could suggest is to inject a simple hook ServerPlayerEntity#closeContainer to run before Container#onContainerClosed to run your code. I forgot what the "ServerPlayerEntity" name equivalent is in 1.12.