Closed PhilippBach closed 2 years ago
The tree-diagram explaining the class structure of the object-oriented implementation still has the old names for the private methods ml_nuisance_and_score_elements and ml_nuisance_tuning (see screenshot below)
ml_nuisance_and_score_elements
ml_nuisance_tuning
https://docs.doubleml.org/stable/_images/oop.svg
Should be nuisance_est and nuisance_tuning instead.
nuisance_est
nuisance_tuning
Changes to be done here https://github.com/DoubleML/doubleml-docs/blob/master/doc/oop.svg
The figure has already been update in the Python and R package repos, e.g. https://github.com/DoubleML/doubleml-for-r/blob/master/man/figures/oop.svg
done in https://github.com/DoubleML/doubleml-docs/pull/84
PhilippBach
commented
2 years ago
Description of the issue or change proposal
The tree-diagram explaining the class structure of the object-oriented implementation still has the old names for the private methods
ml_nuisance_and_score_elementsandml_nuisance_tuning(see screenshot below)https://docs.doubleml.org/stable/_images/oop.svg
Should be
nuisance_estandnuisance_tuninginstead.Changes to be done here https://github.com/DoubleML/doubleml-docs/blob/master/doc/oop.svg
Comments, context or references
The figure has already been update in the Python and R package repos, e.g. https://github.com/DoubleML/doubleml-for-r/blob/master/man/figures/oop.svg