search

DoubleML / doubleml-for-r

DoubleML - Double Machine Learning in R
https://docs.doubleml.org
Other
135 stars 25 forks source link

Optionally skip tests requiring {ranger} #203

Closed MichaelChirico closed 4 days ago

PhilippBach commented 4 days ago

Hi @MichaelChirico

thanks for opening the PR. I guess you've faced some issues regarding ranger. Is this specific to a certain version of ranger?

MichaelChirico commented 4 days ago

Not really. Our test system tries to be lean (in the spirit of include-what-you-use: https://github.com/include-what-you-use/include-what-you-use) & Suggests have to be manually added to tests.

So I come across test suites that fail in this way pretty often. If the fix is simple (as here, a few lines of code) I send it along, I figure there might be a handful of other users out there who can benefit from the test completing without a "hard" error.

That said you are well within the current CRAN rules; feel free to close if you'd rather not be bothered.

Thanks!

PhilippBach commented 4 days ago

Thanks, I see. I think we keep the ranger tests in there, as for us it's an important setting to test. As we have various dependencies that could be skipped, I'm not 100% sure how to handle / skip all or some of them. For now, I'll close this PR, but we keep the issue in our mind. Thanks again!