DoubleML / doubleml-for-r

DoubleML - Double Machine Learning in R
https://docs.doubleml.org
Other
123 stars 25 forks source link

Failing unit test on CRAN solaris #46

Closed MalteKurz closed 2 years ago

MalteKurz commented 3 years ago

See https://www.r-project.org/nosvn/R.check/r-patched-solaris-x86/DoubleML-00check.html

checking tests ... [139s/138s] ERROR
  Running ‘testthat_regression_tests.R’ [138s/138s]
Running the tests in ‘tests/testthat_regression_tests.R’ failed.
Complete output:
  >
  > library("testthat")
  > library("patrick")
  > library("DoubleML")
  >
  > testthat::test_check("DoubleML")
  ── ERROR (test-double_ml_iivm.R:33:3): Unit tests for IIVM: cv_glmnet_dml2_LATE_
  Error: 'NA' indices are not (yet?) supported for sparse Matrices
  Backtrace:
       █
    1. ├─rlang::eval_tidy(code, args)
    2. └─DoubleML:::dml_irmiv(...) test-double_ml_iivm.R:33:2
    3. └─mlr3::resample(task_p, ml_p, resampling_p, store_models = TRUE) helper-11-dml_irmiv.R:91:2
    4. └─future.apply::future_lapply(...)
    5. └─future.apply:::future_xapply(...)
    6. ├─future::value(fs)
    7. └─future:::value.list(fs)
    8. ├─future::resolve(...)
    9. └─future:::resolve.list(...)
   10. └─future:::signalConditionsASAP(obj, resignal = FALSE, pos = ii)
   11. └─future:::signalConditions(...)

  ── ERROR (test-double_ml_irm.R:33:3): Unit tests for IRM: cv_glmnet_dml2_ATE_1_0
  Error: missing value where TRUE/FALSE needed
  Backtrace:
       █
    1. ├─rlang::eval_tidy(code, args)
    2. └─DoubleML:::dml_irm(...) test-double_ml_irm.R:33:2
    3. └─mlr3::resample(task_m, ml_m, resampling_m, store_models = TRUE) helper-10-dml_irm.R:69:2
    4. └─future.apply::future_lapply(...)
    5. └─future.apply:::future_xapply(...)
    6. ├─future::value(fs)
    7. └─future:::value.list(fs)
    8. ├─future::resolve(...)
    9. └─future:::resolve.list(...)
   10. └─future:::signalConditionsASAP(obj, resignal = FALSE, pos = ii)
   11. └─future:::signalConditions(...)
MalteKurz commented 3 years ago

Same errors seem to be present for mlr3viz https://cran.rstudio.com/web/checks/check_results_mlr3viz.html.

MalteKurz commented 3 years ago

In both cases, DoubleML and mlr3viz, the failing unit tests call the cv_glmnet / glmnet learner.

MalteKurz commented 3 years ago

Cause seems to be in glmnet or even in Matrix library. See CRAN checks of glmnet image