DoubleTian-tw / pokemon-Gym

https://pokemon-gym.vercel.app/
9 stars 1 forks source link

fix env #16

Closed QzCurious closed 7 months ago

QzCurious commented 7 months ago

在用 vite 寫 SPA 的時候盡量都用 import.meta.env 來取的 env,不然在前端 (瀏覽器) 是拿不到 process 這個變數的,這是 nodejs 才有的 global 變數。

目前我們還沒有太多什麼是跑在前端,什麼是跑在後端的經驗,我先不多做著墨,但簡單來說:

vercel[bot] commented 7 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @DoubleTian-tw on Vercel.

@DoubleTian-tw first needs to authorize it.

QzCurious commented 7 months ago

vercel 的 env 設定

image

github page 是不用特別設定,因為已經寫在程式碼裡面了

QzCurious commented 7 months ago

我的 PR 這行不應該刪掉,不然 gh-pages 會出問題

image

https://github.com/DoubleTian-tw/pokemon-Gym/pull/16/commits/f4bcb0f5dcaf2503eb2a524f424fcbaeac374f80#diff-58e6f63d87181b1c6a8cb6e5f1691df04aa32854456efcd52ca71c8541375d26

DoubleTian-tw commented 7 months ago

筆記補充為甚麼不能刪掉base