DoubleTrade / lit-datatable

lit-datatable is a material design implementation of a data table, powered by lit-element.
Apache License 2.0
57 stars 12 forks source link

Feature: editing data #23

Closed nandoflorestan closed 4 years ago

nandoflorestan commented 4 years ago

Do we intend to add editing of rows in the future, or will this be for presenting data only?

Is there a roadmap?

Any chance of replacing GPL 3.0 with a more open license? I ask because I believe if I use this component in a commercial application, I might have to publish the source code for the entire application. I would recommend MIT license for this sort of thing...

RoXuS commented 4 years ago

I have updated the license.

To edit, you can already do it by using renderer. Something like this:

        <lit-datatable .data="${data}" .conf="${conf}">
          <lit-datatable-column column property="fruit" .html="${bodyOfFruit}"></lit-datatable-column>
        </lit-datatable>
...
    const bodyOfFruit = (value, property) => html`<input .value="${value}" .label="${property}" />`;

You can use more complexe html with:

    const bodyOfFruit = (value, property) => html`
     ${this.editMode ? html`
       <input .value="${value}" .label="${property}" />` : `<div>${value}</div>`}
    `;
nandoflorestan commented 4 years ago

Thank you very much for changing the license!

You changed it to Apache 2.0 which unfortunately is one of those pain-in-the-ass licenses that pollute code files with legalese. See item 4b in it, for instance. But it is better for this component than GPL 3.0...

I am curious, why was MIT license too big of a jump for you?