search

DoubleYouGTT / hubspot

R package 📦 for working with Hubspot 👩‍💼👨‍💼 data
https://itsalocke.com/hubspot/
Other
10 stars 8 forks source link

Problems with `hs_deals_raw()` #103

Open jonmcalder opened 4 years ago

jonmcalder commented 4 years ago

(1) Doesn't respect the value of the max_properties argument (this was obviously just overlooked and should be easy to remedy)

(2) In certain cases the hubspot API doesn't necessarily return the properties you request but throws in a whole lot of extra properties like some sort of packaged deal...

Options to deal with (2):

  1. Leave all the properties to be returned
  2. Drop the properties and notify
  3. Make extra property dropping toggleable
stephlocke commented 4 years ago

max_properties limits how many we request not how many we receive 😬

jonmcalder commented 4 years ago

As things stand currently max_properties is actually not utilised anywhere in the source code of the function. It should at the very least restrict the number of properties requested. But nevertheless I do receive your point 😉