It looks like the functionality to avoid sending too long a request to hubspot has been lost in translation, at least on the deals functionality.
Before we send a set of properties to the query construction, we should apply properties <- properties[seq_len(max_properties)] when max_properties exists as a variable.
Functions should be checked for this issue and any functions found to have max_properties should have the appropriate truncation and also unit tests that validate we request the truncated amount.
(Note #103 shows that hubspot may send us back more properties than we asked for so testing the return may not be initially the recommended approach)
It looks like the functionality to avoid sending too long a request to hubspot has been lost in translation, at least on the deals functionality.
Before we send a set of properties to the query construction, we should apply
properties <- properties[seq_len(max_properties)]
when max_properties exists as a variable.Functions should be checked for this issue and any functions found to have max_properties should have the appropriate truncation and also unit tests that validate we request the truncated amount.
(Note #103 shows that hubspot may send us back more properties than we asked for so testing the return may not be initially the recommended approach)