search

DoubleYouGTT / hubspot

R package 📦 for working with Hubspot 👩‍💼👨‍💼 data
https://itsalocke.com/hubspot/
Other
10 stars 8 forks source link

get_companies returns nothing #32

Closed maelle closed 4 years ago

maelle commented 4 years ago

not caught by tests though

library("hubspot")
get_companies()
companies <- get_companies()
companies
maelle commented 4 years ago

(companies is something)

stephlocke commented 4 years ago

Returns lots of records for me 🤔 Perhaps we get 0 results when it's been ratelimited or something?

maelle commented 4 years ago

I mean the function itself has no return inside it.

Why use the set names thing?

stephlocke commented 4 years ago

Ah, as I was only interested in the companies cleaned up I hadn't noticed it was returning invisibly when called standalone. hubspot::company_properties() works fine :)

Add return(companies) to make the invisible visible https://github.com/lockedata/hubspot/blob/84e9c3442fd3acc8eb4d764534fb0f4e1f0b5bfc/R/get_companies.R#L57