today I read over your code, as I might want to use your software in my brew setup.
In the PID control stuff there might be a serious problem since commit "Try a new PID calculation"
https://github.com/cmpterman2/SB_Elsinore_Server/pull/28/commits/cfdbdc1b969b76328000d702ea15a4165a6198ba.
In file src/com/sb/elsinore/PID.java, you do not set the fields errorFactor, integralFactor, and derivativeFactor any more. But integralFactor and derivativeFactor are still the base for the calculated return value output, which I think only contains the proportional component of the PID stuff since this commit.
Hi developers,
today I read over your code, as I might want to use your software in my brew setup. In the PID control stuff there might be a serious problem since commit "Try a new PID calculation" https://github.com/cmpterman2/SB_Elsinore_Server/pull/28/commits/cfdbdc1b969b76328000d702ea15a4165a6198ba. In file src/com/sb/elsinore/PID.java, you do not set the fields errorFactor, integralFactor, and derivativeFactor any more. But integralFactor and derivativeFactor are still the base for the calculated return value output, which I think only contains the proportional component of the PID stuff since this commit.
Regards Fred