DougEdey / StrangeBrew

Java based Homebrew Recipe tool
22 stars 10 forks source link

Dropdowns (malt, hops): Edit a line with data already, drop' #82

Closed DougEdey closed 12 years ago

DougEdey commented 12 years ago

Converted from SourceForge issue 1511954, submitted by dlevey

When I am editing a series of malts or hops, I find the following problem: When I re-edit a line which has data in it and I select the drop-down, it automatically selects the value I used from the most-recently edited other line. For example, if Line 1 is Black Patent malt, and I edit Line 2 and add Crystal 60L, if I then go back to Line 1 and select the drop-down it automatically selects (and closes on) Crystal 60L.

This should, instead, maintain the last-selected value for the current line and allow the user to browse.

DougEdey commented 12 years ago

Submitted by dlevey

Logged In: YES user_id=908023

Note: This is on a Windows XP machine

DougEdey commented 12 years ago

Submitted by jeroen_wouters

Logged In: YES user_id=1336491 Originator: NO

Hi Don,

I have created a patch that should fix this bug. Could you perhaps try it out and report your findings? You can find it on the strangebrew sourceforge page as patch 1729506.

Thanks, Jeroen

DougEdey commented 12 years ago

Submitted by dlevey

Logged In: YES user_id=908023 Originator: YES

Um, I must confess ignorance: How do I use/apply a .diff file?

DougEdey commented 12 years ago

Submitted by jeroen_wouters

Logged In: YES user_id=1336491 Originator: NO

I've created a patched jar file for you. You can find it here: http://joenix.studentenweb.org/StrangeBrew/

Jeroen

DougEdey commented 12 years ago

Submitted by dlevey

Logged In: YES user_id=908023 Originator: YES

The jar file, StrangeBrew.jar, doesn't seem to work for me. It doesn't replace an existing file; there is a StrangeBrew_fat.jar but calling the new one instead of that doesn't help. Invoking the jar file directly by executing it (double-click in Windows) gives me an error: "could not find the main class. program will exit"

Trying to download and open the source zip isn't helping either; I can't open the tar file at all (error reading header after 0 entries).

DougEdey commented 12 years ago

Submitted by andrew_avis

Logged In: YES user_id=1135612 Originator: NO

Fixed in 2.0rc2 - thanks Jeroen!