DougEdey / StrangeBrew

Java based Homebrew Recipe tool
22 stars 10 forks source link

Salt.java incorrect labels #91

Open DougEdey opened 12 years ago

DougEdey commented 12 years ago

Converted from SourceForge issue 2322975, submitted by jeferym

Line: new Salt(CALCIUM_SULPHATE, CHALK, "CaSo4", 4.0, new ChemicalEffect[]{ Should be: new Salt(CALCIUM_SULPHATE, GYPSUM, "CaSo4", 4.0, new ChemicalEffect[]{

Line: new Salt(CALCIUM_CARBONATE, GYPSUM, "CaCo3", 1.8, new ChemicalEffect[]{ Should be: new Salt(CALCIUM_CARBONATE, CHALK, "CaCo3", 1.8, new ChemicalEffect[]{

DougEdey commented 12 years ago

Submitted by katzke

I can not find these. I did find that Brewcalcs.java and brewing_salts.csv do have errors in how they refer to Gypsum and Chalk. When I fix them I get an infinity error for the amount of chalk and the SO4 is wrong or messed up. There must be something going on that my no-programmer mind can not find. I think the calculations are correct the labels are just off. I do have a problem with Calcium Chloride not working though. If I chose Chalk then Calcium Chloride will go to zero for my recipe. Problem is I need the Chloride and it shorts me.