search

DougHaber / gqrx-remote

Perl interface for the Gqrx remote control protocol
1 stars 2 forks source link

fix get_demodulator_mode so it no longer causes off by one read line errors #3

Open VVelox opened 5 years ago

VVelox commented 5 years ago

The m command now returns two lines, the second is the width. This module expects the old behavior, which causes it to begin reporting incorrect data.

If get_demodulator_mode is called with out this patch it will return the demodulator used and leave the width in the buffer, which will then be returned when get_demodulator_mode or some other command is issued next.

This now returns a array, the first item being the demodulator and the second being the width.

VVelox commented 5 years ago

BTW major version bumped as this change is non-backwards compatible, but there is no real way past that though given the change to GQRX.

DougHaber commented 5 years ago

Thanks for the pull request. It looks great, and I'm completely fine with breaking reverse compatibility with older versions of GQRX.

One pending thing is updating the tests to match the new behavior of the m command. I can try to find some time soon to take a look and try this out so that we can get this merged.