search

DougReeder / aframe-simple-sun-sky

An A-Frame WebVR sky primitive using a simple (and fast) gradient away from the sun
MIT License
15 stars 2 forks source link

Remove console.log outputs of sun position #2

Closed mattrei closed 5 years ago

mattrei commented 5 years ago

The component logs to the consoles output. Please remove this or hide it within a configurable component's debug flag (default should be false of course).

Thank you.

DougReeder commented 5 years ago

Yes, I want that, too.

On Tue, Feb 19, 2019, 9:53 AM Matthias Treitler notifications@github.com wrote:

The component logs to the consoles output. Please remove this or hide it within a configurable component's debug flag (default should be false of course).

Thank you.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DougReeder/aframe-simple-sun-sky/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXGPsy5bDm3TcsIqHukL8ctzYhaRm9nks5vPA_YgaJpZM4bDJAR .

DougReeder commented 5 years ago

Done.

The flag is named “log”, so it doesn’t conflict with the built-in “debug” component.

On Feb 19, 2019, at 9:53 AM, Matthias Treitler notifications@github.com wrote:

The component logs to the consoles output. Please remove this or hide it within a configurable component's debug flag (default should be false of course).

Thank you.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Doug Reeder reeder.29@gmail.com Recall your notes by context, with Serene Notes: https://serenenotes.hominidsoftware.com/ My gender pronouns are: he, him, his.

mattrei commented 5 years ago

cheers