compilation error (vala)

[GoogleCodeExporter]

What steps will reproduce the problem?
Won`t compile

What is the expected output?

/usr/bin/valac --vapidir=../vapi --vapidir .. --vapidir ../vapi --pkg
configmake --pkg config \
                -C \
                -H globalmenu-settings.h \
                --library=globalmenu-settings \
                --vapi=globalmenu-settings.vapi \
                settings.vala global-settings.vala local-settings.vala  \
                --pkg gtk+-2.0 \
                --pkg gdk-x11-2.0
settings.vala:155.3-155.62: warning: unhandled error `GLib.KeyFileError'
                keyfile.load_from_data(data, data.length, KeyFileFlags.NONE);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
settings.vala:42.28-42.34: error: Argument 1: Cannot convert from
`Gdk.XEvent*' to `X.Event*'
                return real_event_filter(&xevent, event);
                                         ^^^^^^^
Compilation failed: 1 error(s), 1 warning(s)
gmake[2]: *** [vala-ccode] Error 1
gmake[2]: Leaving directory `/usr/src/gnome/gnome-globalmenu/libsettings'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/src/gnome/gnome-globalmenu'
gmake: *** [all] Error 2

What version of the Global Menu are you using? On what operating system?
latest from GIT

What version of Vala are you using? (if your Global Menu is built from git)
0.7.10

Original issue reported on code.google.com by dimitrov...@gmail.com on 10 Feb 2010 at 2:17

• Merged into: #598

[GoogleCodeExporter]

I can confirm this. There is a problem when trying to compile with 0.7.10 and 
above. 
I've made some corrections that will allow you to compile it.

best regards,
Otávio Ribeiro

Original comment by otavio.ribeiro on 19 Feb 2010 at 4:25

Attachments:

• patch.diff

[GoogleCodeExporter]

There is also another same mistake in /libsettings/settings.vala 

settings.vala:155.3-155.62: warning: unhandled error `GLib.KeyFileError'
                keyfile.load_from_data(data, data.length, KeyFileFlags.NONE);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
settings.vala:42.28-42.34: error: Argument 1: Cannot convert from `Gdk.XEvent*' 
to
`X.Event*'
                return real_event_filter(&xevent, event);
                                         ^^^^^^^
Compilation failed: 1 error(s), 1 warning(s)
make[2]: *** [vala-ccode] Error 1
make[2]: Leaving directory `/home/dc/gnome-globalmenu/libsettings'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/dc/gnome-globalmenu'
make: *** [all] Error 2

and in /libsettings/settings.c

settings.c: In function ‘gnomenu_settings_real_event_filter’:
settings.c:165:4: error: lvalue required as unary ‘&’ operand
settings.c: In function ‘gnomenu_settings_get_by_atom’:
settings.c:511:2: warning: passing argument 10 of ‘gdk_property_get’ from
incompatible pointer type
/usr/include/gtk-2.0/gdk/gdkproperty.h:50:10: note: expected ‘guchar **’ 
but argument
is of type ‘char **’
make[4]: *** [libsettings_la-settings.lo] Error 1
make[4]: Leaving directory `/home/dc/gnome-globalmenu/libsettings'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/dc/gnome-globalmenu/libsettings'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/dc/gnome-globalmenu/libsettings'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/dc/gnome-globalmenu'
make: *** [all] Error 2

Make Error seemed to tell me I should Change line 165: * to & xevent, so I did.

then It shows line 165:77 is wrong 

settings.c: In function ‘gnomenu_settings_real_event_filter’:
settings.c:165:77: error: request for member ‘xproperty’ in something not a 
structure
or union
settings.c: In function ‘gnomenu_settings_get_by_atom’:
settings.c:511:2: warning: passing argument 10 of ‘gdk_property_get’ from
incompatible pointer type
/usr/include/gtk-2.0/gdk/gdkproperty.h:50:10: note: expected ‘guchar **’ 
but argument
is of type ‘char **’
make[4]: *** [libsettings_la-settings.lo] Error 1
make[4]: Leaving directory `/home/dc/gnome-globalmenu/libsettings'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/dc/gnome-globalmenu/libsettings'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/dc/gnome-globalmenu/libsettings'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/dc/gnome-globalmenu'
make: *** [all] Error 2

Original comment by doublec...@gmail.com on 1 Apr 2010 at 5:20

[GoogleCodeExporter]

Original comment by rainwood...@gmail.com on 10 May 2010 at 2:15

• Changed state: Duplicate