Unfollow

[blastoise186]

Please check the following boxes

• [x] I've read and agree to the Contribution Guidelines and to the Code of Conduct
• [x] I've checked that I didn't commit sensitive information like tokens or other login information
• [x] I haven't hardcoded any IDs or anything else that shouldn't be (with the exception being permissions)
• [x] I tested my code and I verified it's working to the best of my ability
• [x] I checked if my code doesn't violate the styleguide with npm test

Describe your pull request

This Pull Request is intended to create an Unfollow command, to allow users the ability to unfollow or unsubscribe from posts on Zendesk.

I borrowed the existing follow command as a base, so it should be mostly valid.

With assistance from @MoonlightCapital I've managed to get the PR to a point where it should be mostly ready, but I'm not completely sure how to grab the Subscription ID.

As such, the PR might not be ready just yet, but I think it's close.

Any thoughts?

[blastoise186]

Hmm, working on this with Moon, please wait

[blastoise186]

Sorry for the mess, Moon's helping me fix this.

[MoonlightCapital]

Finally the Travis checks passed, though I'm not sure the command will work as intended... We had no proper way to test this, as the parameters Zendesk wants to delete a subscription are kinda weird...

[blastoise186]

This is about as close as I think I can get, based on how other items are written in the zendesk.js file

[blastoise186]

this PR has been withdrawn and closed

[blastoise186]

possibly fixes #95 by @spudpotato

[Kitty-Therapist]

Thank you for putting in a pull request, I appreciate that you want to help out.

However, I'm afraid that I cannot accept this pull request for several reasons:

• There are a lot of commits on this pull request, but most of these have descriptions that have absolutely no relevance to what the commit itself changes. It is quite a bit spammy and only pollutes the commit history, making backtracking changes to debug issues in the future harder.
• In addition to the above there even seem to be multiple commits that make the exact same changes, this only furthers pollutes the timeline and makes it harder to follow.
• From looking at the code, I do not believe this is the effective way of how it should be done. I do feel like that it is possible to come up with a cleaner approach.

So, here's what I am going to recommend here:

• If you commit changes please make the message reflect the change itself, this can be general, like "added an unfollow command", or specific as needed "fixed a variable name". This helps to see what exactly changed when in the future.
• Adding commits to a PR after changes are requested is fine, but in this PR there are just so many commits over such a long period. Relatively speaking, not that many lines of code are added/changed. They would be better squashed into one condensed commit covering all changes.
• Contributions to this repository are meant to improve the bot and help the community. As such people trying to "beat" others to a fix, or people considering them "their legacy" are only counter productive and have no place on this repository. If you really want to consider it that, you are free to think it in your mind, but keep it to yourself and out of this repository please.