Closed blastoise186 closed 5 years ago
30 seconds is a little too long for my liking, the idea is that you already certainly know some suggestions need to be merged and checked/verified the content beforehand, if you still need to check the content while the confirmation is ongoing you're doing it wrong 😄 . The confirmation is just to confirm to you that you're merging the correct suggestions.
ah ok, would 20 be a little more effective?
Personally, I think 10 is already generous enough, but 20 works too.
20 seconds it is then. Thanks!
The Dupe Confirm Timeout being at 10 seconds is a bit fast, let's try 30
Please check the following boxes
npm test
- I'm only changing one number in this instance, making this stage unnecessaryDescribe your pull request
Thanks for the work so far on adding Dupe Confirmation and Undupe capabilities with #36 . I've noticed the 10 second timeout is a little fast, so maybe 30 seconds might be a bit easier for anyone who doesn't quite have lightning fast reactions.
This Pull Request changes the timeout from 10 seconds to 30 seconds on the Dupe Confirmation.