Gained EXP calculated incorrectly/unclearly

[drdrjojo]

Describe the bug The gained EXP doesn't match the real EXP gained/logs.

To Reproduce Steps to reproduce the behavior:

0. Note down the current EXP
1. Fill the queue with dupes and invalid comments
2. Proceed the queue
3. Check the logs with !stats
4. Wait for MegaBots debriefing
5. Check for conformities (and your new EXP stats)

Expected behavior MegaBots debriefing should show how much EXP you gained since the last debriefing.

Screenshots

Additional context !cat

[Dougley]

Debriefings only take EXP into account that are granted via admin actions (aka reports), things like the daily reward are not included in this metric.

[drdrjojo]

You can see in the logs that "Reported invalid submission" appears up to 4 times and "Merged a suggestion" up to 5 times (aka reports) If I use my calculator it should be minimum gained 120 EXP

[Dougley]

Do you have a better example of this behavior?

[drdrjojo]

I might check on next debriefing to get a before/after exp stats.

But you might look at this part of the code: https://github.com/Dougley/MBv2/blob/854dac0f90e995d017f52dddc6db19b1485c7653/src/features/exp.js#L172 If I understood it correctly the exp are rewarded before and afterward its checking if the user can get more exp, so in most case the last dupe is not counted

[drdrjojo]

Here are the logs with my last debriefings (removed non-reports EXP)

+20 "Merged a suggestion" +20 "Merged a suggestion"

40 EXP - Debriefing: 40 EXP ✔️

+20 "Merged a suggestion"

20 EXP - Debriefing: 20 EXP ✔️

+5 "Reported invalid submission" +20 "Merged a suggestion" +5 "Reported invalid submission" +20 "Merged a suggestion" +5 "Reported invalid submission" +5 "Reported invalid submission" +5 "Reported invalid submission" +5 "Reported invalid submission" +5 "Reported invalid submission" +5 "Reported invalid submission" +3 "Reported a comment" +5 "Reported invalid submission"

88 EXP - Debriefing: 68 EXP ❌