search

DoumanAsh / opusic-sys

Rust bindings to libopus
Boost Software License 1.0
9 stars 7 forks source link

Fix libopus build on 64-bit linux #12

Closed Ralith closed 3 years ago

Ralith commented 3 years ago

Fixes #9

DoumanAsh commented 3 years ago

https://github.com/DoumanAsh/opusic-sys/pull/12/checks?check_run_id=3935364568#step:5:13

DoumanAsh commented 3 years ago

If we want to make more portable we can consider to set cmake LIBRARY_OUTPUT_DIRECTORY property to a directory where we want to store artifacts that are considered library The easiest way is to make it via global cmake variable CMAKE_LIBRARY_OUTPUT_DIRECTORY

Ralith commented 3 years ago

Ah, I'll look into that. I'm pretty mystified by why Ubuntu is failing; different cmake versions maybe?

DoumanAsh commented 3 years ago

@Ralith if you have troubles I can do it myself and you can check that it works fine on your machine?

Ralith commented 3 years ago

Sure, that's fine too. I'm just wrapping up for the night here, but I can report back with test results tomorrow morning.

DoumanAsh commented 3 years ago

@Ralith I made commit which overrides output directory for lib. Please try to verify it on your system, to see if it works

Ralith commented 3 years ago

Works great, thanks!

DoumanAsh commented 3 years ago

@Ralith I've published 0.3.6

Ralith commented 3 years ago

Awesome!