Make SliderMenuOptions a property of SliderMenuViewController

[ferusinfo]

I can easily spot a case where you want to have different settings for different sliding view controllers in your application (as in my case).

Therefore I propose that SliderMenuOptions would be a property of the SliderMenuViewController you are inheriting, so changing one setting of the Menu won't affect other sliding menu controllers.

What do you think about it?

[Douvi]

Look at the other issue I gave you a solution.

link

[ferusinfo]

The whole idea behind GlobalVariables is kinda confusing at start (and I am in the industry for quite long time), so I think in the future you need to document it a little bit better :)

Also - extending the GlobalVariables protocol in other files creates a lot of code that you don't need - especially when you want to change only single property of the options.

[Douvi]

For GlobalVariables, I will need to setup a documentation, that true. But for the implementation I did not found a better way to do it. Because the menu need ti check the same variables at different points of the process to different class (click, swipe, opening menu, closing menu, etc). So, it was easier to create a protocol with all methods needed with it's own extension to be able to have a single implementation.

[ferusinfo]

Are you open to changes? I will try to find a solution when I have more time :)

[Douvi]

No problem you can send a pull request 👍 when you have an idea