search

DouweM / pebblewatch

A Ruby library for communicating with your Pebble smartwatch.
MIT License
60 stars 8 forks source link

Added class to handle Pebble bundles. #3

Closed phistep closed 11 years ago

phistep commented 11 years ago

Created a class to handle the information in Pebble bundles. Might be handy when trying to implement app/firmware upload. This implements the file structure as reported here. The actual implementation is similar to the Python libpebble.

I also added an example file to show case the API.

DouweM commented 11 years ago

The code itself looks fine, I just have some style complaints. Nice work otherwise!

DouweM commented 11 years ago

Also, please make mention of this in the readme, in the same place I mention Pebble::Protocol for example.

phistep commented 11 years ago

I have fixed everything but lazy initialization (see line comment above). Shall I also convert tab indentation to two spaces?

DouweM commented 11 years ago

I see you've already fixed everything—awesome. I'll pull it in later tonight.

phistep commented 11 years ago

Yay! This was probably my first contribution to a actually useful tool ever! (if you don't count OS X homebrew)

DouweM commented 11 years ago

Keep up the good work! Your next two contributions could be fixes for your own issues #1 and #2 ;)