search

Doveps / mono

Code for Doveps projects
http://doveps.com
MIT License
0 stars 0 forks source link

Fix tests #27

Closed JosiahRegencia closed 7 years ago

JosiahRegencia commented 7 years ago

For issue #25

JosiahRegencia commented 7 years ago

Not sure why it shows failed in here. It clearly shows that it passed in travis: https://travis-ci.org/Doveps/mono/builds

greenmoss commented 7 years ago

Hi @JosiahRegencia the code climate thing is something I added. You can ignore it. I think I should remove it so we don't get an ugly red "X".

greenmoss commented 7 years ago

I think the scanner results need to be set aside somewhere, as they are for test purposes only. If you leave them directly in the local directory, they will also be created when someone new checks out the code. That would give the new person a set of scan results that they didn't create.

greenmoss commented 7 years ago

Need to fix the conflicting .travis.yml

greenmoss commented 7 years ago

Please reduce the amount of lines in the 33.33.33.5* files. You only need a few lines in there: "just enough to get the test to pass". Otherwise it adds a lot of un-needed size in the repository.

greenmoss commented 7 years ago

The db stuff looks like it took a while, so I moved it into #28.

JosiahRegencia commented 7 years ago

@greenmoss But I need the scanner results in the repository so that travis can be able to read them.