search

Doveps / mono

Code for Doveps projects
http://doveps.com
MIT License
0 stars 0 forks source link

New dockerstuff #97

Closed JosiahRegencia closed 6 years ago

JosiahRegencia commented 6 years ago

Used docker-compose run savant bash test.sh as the command to run tests.

Build passed in

https://travis-ci.org/Doveps/mono/builds/342182114

greenmoss commented 6 years ago

Please resolve the conflicts

JosiahRegencia commented 6 years ago

Did you mean in codeclimate?

greenmoss commented 6 years ago

Check out the "resolve conflicts" button. It means there was code committed on master, then conflicting code committed on this branch:

https://github.com/Doveps/mono/pull/97/conflicts

greenmoss commented 6 years ago

I did a deeper dive into this, and I think there are some problems with the Dockerfile. I detailed next steps in #99. Please take care of #99 first, then revisit this PR.

greenmoss commented 6 years ago

I think this is no longer needed. Let me know if you want to keep it open.