search

DovieW / middle-click-search

A Chrome extension. Click middle mouse button to search text in google, or go directly to links.
https://chromewebstore.google.com/detail/middle-click-to-search/mmelcmhpbfmnchbofbjkffmmelkdmiaj?hl=en
GNU General Public License v3.0
2 stars 1 forks source link

Doesn't work at all #11

Open KingPsychopath opened 5 months ago

KingPsychopath commented 5 months ago

Going to attempt to make a PR when I have the time but it the middle click does not work at all in Edge or Arc

Using a MacBook Pro and separate mouse for middle click as well as middle click gesture from the Better Touch Tool extension.

DovieW commented 5 months ago

I've tested it in Edge and Arc (on Linux and Windows, don't have mac) and it works

So this sounds like either or a Mac issue, or it's specifically with the kind of input that you're using. Maybe you can see if those inputs are considered different input types and open a PR to add them

KingPsychopath commented 5 months ago

I've tested it in Edge and Arc (on Linux and Windows, don't have mac) and it works

So this sounds like either or a Mac issue, or it's specifically with the kind of input that you're using.

Maybe you can see if those inputs are considered different input types and open a PR to add them

Appreciate the response, I'll give it a test on my Windows machine; been waiting for work to die down before I make a PR and take a look at the edge cases of MacOS.

KingPsychopath commented 5 months ago

Upon some testing, it only behaves this way on reddit (their latest version not 2.0) or other websites that trap focus and pop-up some JS element like the embed button/pop-up in my video. Upon middle click, it de-selects the text.

Disabled the element and JS in console, and still faced the same issue. I'll provide updates here if I fix it but the extension does work everywhere else, just a shame the one website where I'd use it most it does not.

https://github.com/DovieW/middle-click-search/assets/6223066/ae05c047-acbf-4010-9ae7-69fd2e01c81a

DovieW commented 5 months ago

strange. it seems to work fine for me on reddit. im not sure which version of reddit though. heres a screenshot with hopefully enough UI for you to see what version im using and the text that i tested it on: image

DovieW commented 5 months ago

it seems i actually made an issue for this a while ago, but i dont know how to reproduce it

10

KingPsychopath commented 4 months ago

Sorry, I've been busy with work, will try work on this now but it's the version after the current version you are using.

So not https://new.reddit.com/ which when you click a post it opens as an overlay element that you can click out of, a newer version they have been slowly rolling out since the beginning of this year, where trying to expand messages and posts leads you to a new page (sucks!).

@DovieW I reproduced it by trying to select and middle click a post from the link. Not sure if that will work for you? https://sh.reddit.com/

[source](https://webapps.stackexchange.com/questions/173926/what-is-sh-reddit-com-and-old-reddit-com-exactly-its-not-just-a-theme#:~:text=Jonathan%20Tien%20(%2Fu%2Fricefield,posts%20about%20it%20on%20Reddit.)

strange. it seems to work fine for me on reddit. im not sure which version of reddit though. heres a screenshot with hopefully enough UI for you to see what version im using and the text that i tested it on: image

DovieW commented 4 months ago

In the screenshot the UI is from the sh.reddit Here's a video: https://github.com/DovieW/middle-click-search/assets/32934685/6876426b-0c65-426b-ba0e-00d35e5345cf