DozerDB / dozerdb-core

DozerDB Plugin Core Project
GNU General Public License v3.0
17 stars 1 forks source link

Multiple databases beyond 100 #11

Open kushankurdas opened 3 months ago

kushankurdas commented 3 months ago

I am running 4.4 versions and able to create upto 100 database but beyond that it throws error I tried modifying dbms.max_databases to 1000 but its not reflecting

I am planning to use this project in production hence looking for a immediate solution

kushankurdas commented 3 months ago
Screenshot 2024-03-06 at 19 46 28
jmsuhy commented 3 months ago

I checked and it is because the max dbs was hard coded to 100.

We will get that fixed so it honors the dbms.max_databases in both 4.x and 5.x versions.

jmsuhy commented 3 months ago

Here is the issue in the MultiDatabaseManager class. The next push will allow for the configuration option to be set.

private void checkDatabaseLimit(NamedDatabaseId namedDatabaseId) {

        // TODO:  Get the actual count from the Graph configuration.
        if (databaseRepository.registeredDatabases().size() >= 100) {
            throw new DatabaseManagementException(
                    "Could not create gdb: " + namedDatabaseId.name() + " because you have exceeded the limit of 100.");
        }
    }
jmsuhy commented 3 months ago

We need to enforce a minimum of 2 for the default and system database. So any option > 2 will be acceptable for the first version.

kushankurdas commented 3 months ago

Awesome, Let me know if there are ways to contribute to this project, since I am also experimenting with this

jmsuhy commented 2 months ago

We updated the 5.x version and will update the 4.x version next.