Dr-Eberle-Zentrum / Data-projects-with-R-and-GitHub

6 stars 3 forks source link

Comments for Jan by Sarah #249

Closed sarahloeber closed 6 days ago

sarahloeber commented 3 months ago

Hi Jan,

this is a very nice project idea! I think you’ve provided a detailed description and the aim and background of the project as well as the scope are clear and understandable. A few remarks:

I tried downloading a subset of the data twice but the website just times out after a while. Would it be possible to narrow the products down to a smaller number e.g. 10.000 and share the dataset on GitHub? That makes it more accessible if more people have that problem.

As I cannot access the data set, could you elaborate on the categorization variable description and what exactly they contain? What you described in the note was not clear to me without having access to the dataset. I’m guessing it’s about the food groups the products belong to, but it’s slightly confusing this category is two variables.

I think a bubble plot is a really good idea to get the point across and can tell us a lot about the data. I’d be interested in how the colouring for this graph has been decided since there are only four colours for five scores. Also good remark about the in-between cases. Maybe it’s an idea to work with shapes in those cases although I have to admit those don’t give you much information about the values…

Best, Sarah

jan-thiele7 commented 3 months ago

Hi Sarah,

thank you for your feedback, I hope I can give you more information on your points mentioned:

  1. Yes, accessing the dataset is kinda tricky. Martin gave me the same feedback and he figured out a way to just read in a portion of the data set, so I will include that in the final description.
  2. The data set uses two categorization variables, they are just called differently depending on the way the data was downloaded. They differ in their level of detail. For example, pnns_group_1 contains the category "Milk, yoghurt and dairy" while pnns_group_2 splits this up in "Milk", "dairy", and "yoghurt". In the original project we used both variables and comnbined some of them. Do you think I should provide a table how the different categories should be grouped?
  3. I will include pictures for the Nutri- and Ecoscore labels so people can get the RGB values or Hex codes. The coloring of the circles could be done by splitting the circle in half or by using an outer and inner ring.

Hope these information to better understand the project. Thank you for your feedback, I'll make sure to include it. Best regards, Jan