search

Dr-Noob / cpufetch

Simple yet fancy CPU architecture fetching tool
GNU General Public License v2.0
1.88k stars 103 forks source link

[ARM][Android]Kirin960 not being detected correctly #157

Closed QQxiaoming closed 2 years ago

QQxiaoming commented 2 years ago

Hi Dr, it's me again.😁

I have an old Android device Kirin960 from Honor 9. I just tried cpufetch out of curiosity. like this：

Screenshot_20220921_235949_com cpuid cpu_z

So I installed termux, and built cpufetch. got this:

Screenshot_20220921_234213_com termux

I looked into it, maybe change "Hi" and "Hi3660" inside match_hisilicon to "hi" and "hi3660" and then I'll get this:

Screenshot_20220921_234345_com termux

The end, sorry I'm not a native English speaker, maybe my expression is not very good.

Dr-Noob commented 2 years ago

Hey, thanks for the report.

This is the first time I ever see cpufetch running in a Kirin SoC since I added support for it (which was around two years ago :sweat_smile:). Looks like SoC names are reported with "hi" instead of "Hi" - I updated the master branch with that change, can you confirm it works as expected?

QQxiaoming commented 2 years ago

Awesome, it works as expected now.