Dr-Noob / cpufetch

Simple yet fancy CPU architecture fetching tool
GNU General Public License v2.0
1.91k stars 103 forks source link

wrong core name on i7-8565U: should be "Whiskey Lake", not "Comet Lake" #298

Closed miku closed 1 month ago

miku commented 1 month ago

As the title says, the Microarchitecture field seems to be off on an i7-8565U, which is an 8th gen Intel Core CPU, codenamed Whiskey Lake (not Comet Lake).

  1. Exact CPU Model: Intel Core i7-8565U
  2. Operating System: Linux, Debian 12.7
  3. Output of cpufetch
$ cpufetch 

                                                              Name:              Intel Core i7-8565U
                                                              Microarchitecture: Comet Lake
                                                              Technology:        14nm
                                                              Max Frequency:     4.600 GHz
                                                              Cores:             4 cores (8 threads)
                                                              AVX:               AVX,AVX2
                                                              FMA:               FMA3
                                                              L1i Size:          32KB (128KB Total)
                                                              L1d Size:          32KB (128KB Total)
                                                              L2 Size:           256KB (1MB Total)
                                                              L3 Size:           8MB
                                                              Peak Performance:  588.80 GFLOP/s
  1. Debug:
$ cpufetch -d
cpufetch v1.02 (Linux x86_64 build)
Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz
- Max standard level: 0x00000016
- Max extended level: 0x80000008
- CPUID dump: 0x000806EC

Refs:

Dr-Noob commented 1 month ago

Interesting! I saw your patch (#297), but it's incorrect. The CPUID 000806EC can correspond to either Whiskey Lake (e.g., your CPU) or Comet Lake (e.g., this CPU).

I have pushed a new patch to main, can you please build from source and check if that works as expected?

miku commented 1 month ago

Thanks for the clarification @Dr-Noob - as the CPUID is

a combination of the processor family, processor model, and processor stepping

I assumed it to be unique (per cpu designation), but seemingly I was wrong.

Patch on main now yields "Whiskey Lake", as expected on a i7-8565U.

Dr-Noob commented 1 month ago

Well, CPUID is supposed to be unique, and it actually is in >99% of the cases. But, for some reason I don't yet understand, Intel messed it up in the Kaby Lake/Whiskey Lake/Comet Lake CPUs and there are clashes sometimes. I would like to find an official answer for this but I don't have it at the moment. In the meantime I just try to make cpufetch as accurate as possible, so thanks for reporting. Glad to know it works properly, closing the issue :+1: .

miku commented 1 month ago

Thanks for this awesome project.