First message loading issue due to rate_limiting

smrchanda877 commented 22 hours ago

I have noticed an issue with the UI and response, when the user enters the first message it is loading 2 times and sometimes it is throwing an error from the api due to too many calls. I have fixed that issue but for fixing it, I had to comment handle_rate_limiting function from ddos_protection.py. When I comment that function, it works fine. When I uncomment it, the first message from the user doesn't get any response.

The semi-fixed and restructured code is in the branch first-message-bug-fix.

@ACraig7 @itsnotmik Can you please look into this? If you are unsure about anything or didn't face any issue, let me know. I can help in reproducing the issue

ACraig7 commented 18 hours ago

Fixed in #192 by moving handle_rate_limiting function call.

ACraig7 commented 16 hours ago

Merge in #192

itsnotmik commented 16 hours ago

I pushed a changed to first-message-bug-fix after @ACraig7 had already fixed it. So I reverted my code and repushed. Your branch should be unaffected @smrchanda877

itsnotmik commented 14 hours ago

@smrchanda877 @ACraig7 check out first-message-bug-fix now. It includes the change that removes cookies. Which me and andrew suspect is the reason for the double load and the loading bars not appearing when loading vector store

smrchanda877 commented 14 hours ago

Man. the issue is fixed. I think cookies were rerunning the code, whenever anything related to it updates. @itsnotmik Great fix. I'm so glad this issue is fixed, now the whole flow looks good

DrAlzahraniProjects / csusb_fall2024_cse6550_team1

First message loading issue due to rate_limiting #191