DrCyanide / cyanic-sd-krita

A Stable Diffusion plugin for Krita, compatible with A1111 and SD.Next
68 stars 4 forks source link

Feature request: Auto-updating inpainting masks #15

Closed Miraihi closed 10 months ago

Miraihi commented 10 months ago

The title. While you're aware of this request, it won't hurt to keep things organized.

It gets a bit annoying when you complete a set of generations on one portion of the image and shift to the next, but then generate over the old mask upon hitting the "generate" just because you've forgot to manually update the mask.

I think you can go about that by automatically generating a layer named "Inpaint mask" upon shifting to the "inpainting" tab, and everything drawn on this layer will count as a mask (Photoshop extension does that. Also it constantly reminds you to select the region to work on so you can never forget.)

DrCyanide commented 10 months ago

I'm brainstorming how to implement this, and I want to run some possible options past you.

Right now if you don't manually use the "Use Selection"/"Use Layer"/"Use Canvas" buttons before you click "Generate" the first time, the program assumes you want to Use Canvas and that your active layer is your mask. I think it makes sense to keep that as the default behavior, rather than creating a new layer automatically for the user (which could be irritating if someone accidentally selected Inpaint)

What I'm considering adding (as checkbox options):

Do these options sound useful? Is there any other option that would make sense to add?

Miraihi commented 10 months ago

Right now as it's defaulting to the selection when on Inpaint tab it's already making a huge difference in usability. Updating the mask when I hit "Generate" is about what I expect intuitively, as it removes one excessive action I otherwise have to perform every single time.

Adding results below mask sounds nice, hiding mask is also useful (Other plugins do exactly that).

DrCyanide commented 10 months ago

Pushed - Have fun! Thanks for all your help improving this plugin.