Error in TRO_Utilities.h, not cloud_in found

[DanielEliasib]

I think there is an error in this line. Following other places where cloud_in appears it seems that the parameter in this function should be cloud_in instead of cloud or it should be cloud instead of cloud_in in here.

[DrGabor]

Hi, Daniel, thanks for your comments! This error has already fixed.

[DanielEliasib]

Hi, I closed the issue because I thought this was fixed but I'm pretty sure that it need to be updated here too, after modifying that line and jumping through a lot of hoops I was able to compile and run the .exe

[DrGabor]

Hi Daniel, 

Thanks for your patient. It is weid that my compiler didn't report this error. Thank you very much!

 

------------------ 原始邮件 ------------------ 发件人: "DrGabor/WinTeaser" <notifications@github.com>; 发送时间: 2020年12月18日(星期五) 凌晨3:26 收件人: "DrGabor/WinTeaser"<WinTeaser@noreply.github.com>; 抄送: "280868861"<280868861@qq.com>;"Comment"<comment@noreply.github.com>; 主题: Re: [DrGabor/WinTeaser] Error in TRO_Utilities.h, not cloud_in found (#1)

Hi, I closed the issue because I thought this was fixed but I'm pretty sure that it need to be updated here too, after modifying that line and jumping through a lot of hoops I was able to compile and run the .exe

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[DanielEliasib]

Hi! I think those where the only errors I found, I had another problem with pmc, it would not compile because of some headers that are not available on windows, I kinda fixed it using libunistd. I'm not sure how you were able to compile but if someone else is having some trouble with sys/time.h, unistd.h or getopt.h that might help!

Thanks for your work!

[DrGabor]

Hi Daniel,  Indeed, I had met these errors before, and I re-wrote those headers in my own computer. I will upload these headers soon and list your solution in readme.txt as well. I sincerely appreciate your advice!

---Original--- From: "Daniel Eliasib"<notifications@github.com> Date: Tue, Dec 22, 2020 23:14 PM To: "DrGabor/WinTeaser"<WinTeaser@noreply.github.com>; Cc: "Comment"<comment@noreply.github.com>;"Di Wang"<280868861@qq.com>; Subject: Re: [DrGabor/WinTeaser] Error in TRO_Utilities.h, not cloud_in found (#1)

Hi! I think those where the only errors I found, I had another problem with pmc, it would not compile because of some headers that are not aviable on windows, I kinda fixed it using libunistd. I'm not sure how you were able to compilem but if someone else is having some trouble with sys/time.h, unistd.h or getopt.h that might help!

Thanks for your work!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[DrGabor]

Hi Daniel, There are someother issues worthy to be mentioned. Firstly, the pmc library seems to be wrong when the number of point pairs is too large. This is because pmc uses omp library. If you meet this issue, just use ordinary for loop instead of omp for loop. Secondly, the running time of teaser can be hours since the maximum clique searching in pmc library. To save the time, you can change the configuration of Teaser. There is a maximum pmc search time in the constructor of Teaser. Both of the above issues may be occurred when the number of input point pairs is large (I think it is around 10000). Therefore, you can enlarge the feature radius to reduce the point pair number.

---Original--- From: "Daniel Eliasib"<notifications@github.com> Date: Tue, Dec 22, 2020 23:14 PM To: "DrGabor/WinTeaser"<WinTeaser@noreply.github.com>; Cc: "Comment"<comment@noreply.github.com>;"Di Wang"<280868861@qq.com>; Subject: Re: [DrGabor/WinTeaser] Error in TRO_Utilities.h, not cloud_in found (#1)

Hi! I think those where the only errors I found, I had another problem with pmc, it would not compile because of some headers that are not aviable on windows, I kinda fixed it using libunistd. I'm not sure how you were able to compilem but if someone else is having some trouble with sys/time.h, unistd.h or getopt.h that might help!

Thanks for your work!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[DanielEliasib]

mmhhh that might be a big problem because I'm trying to implement this in a real time application, I will check this out, if it's too slow I will have to search for other options. Thank you for the advise!

[DrGabor]

Hi Daniel,

If you meet some problems with real data, please tell me and send some sample data to me, and I am quite interested to see the power of Teaser++.

[DanielEliasib]

First of all, thank you for uploading the linux libraries I was having trouble with libunistd while compiling to a dll, your libraries where very useful. Sadly I don't know if I can share data because of a nda, I will see what I can do.

I will let you know if I find other problems. Thank you for your help :)

[DrGabor]

Hi Daniel, thanks for your valuable advices too. 

---Original--- From: "Daniel Eliasib"<notifications@github.com> Date: Fri, Dec 25, 2020 00:10 AM To: "DrGabor/WinTeaser"<WinTeaser@noreply.github.com>; Cc: "Comment"<comment@noreply.github.com>;"Di Wang"<280868861@qq.com>; Subject: Re: [DrGabor/WinTeaser] Error in TRO_Utilities.h, not cloud_in found (#1)

First of all, thank you for uploading the linux libraries I was having trouble with libunistd while compiling to a dll, your libraries where very useful. Sadly I don't know if I can share data because of a nda, I will see what I can do.

I will let you know if I find other problems. Thank you for your help :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.